Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix - Validation status when requesting a new validation after reject #19129

Merged
merged 3 commits into from
Mar 6, 2025
Merged

Fix - Validation status when requesting a new validation after reject #19129

merged 3 commits into from
Mar 6, 2025
+76 −4

Conversation

RomainLvr
Copy link
Contributor

@RomainLvr RomainLvr commented Mar 4, 2025 •
edited by cedric-anne
Loading

Checklist before requesting a review

Please delete options that are not relevant.

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.
  • This change requires a documentation update.

Description

  • It fixes !36625
  • Here is a brief description of what this PR does

This PR fixes an issue where, after rejecting an approval request and submitting a new one, the approval status incorrectly remains Rejected instead of changing to Waiting for approval

@RomainLvr RomainLvr self-assigned this Mar 4, 2025
@RomainLvr RomainLvr requested review from Rom1-B and stonebuzz March 4, 2025 14:32
Rom1-B
Rom1-B suggested changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@Rom1-B Rom1-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests

@trasher
Copy link
Contributor

trasher commented Mar 5, 2025

Please consider adding tests is always required.
Just leave a note when there is a reason not to add them.

@RomainLvr RomainLvr requested a review from Rom1-B March 5, 2025 08:52
@cedric-anne cedric-anne added this to the 10.0.19 milestone Mar 6, 2025
@cedric-anne cedric-anne added the bug label Mar 6, 2025
@cedric-anne cedric-anne merged commit 6b2250c into glpi-project:10.0/bugfixes Mar 6, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trasher trasher trasher approved these changes

@stonebuzz stonebuzz stonebuzz approved these changes

@Rom1-B Rom1-B Rom1-B approved these changes

@cedric-anne cedric-anne cedric-anne approved these changes

@AdrienClairembault AdrienClairembault AdrienClairembault approved these changes

Assignees

@RomainLvr RomainLvr

Labels
bug
Projects
None yet
Milestone
10.0.19
Development

Successfully merging this pull request may close these issues.
6 participants
@RomainLvr @trasher @stonebuzz @Rom1-B @cedric-anne @AdrienClairembault